mirror of
https://github.com/zvx-echo6/meshai.git
synced 2026-06-10 17:04:45 +02:00
K7ZVX
20e0dec28a
Phase 2.16 found the live notification pipeline never delivered any
environmental event. Two independent blocking bugs, both fixed here.
BUG A -- grouper held events forever (nothing drove tick()).
Every adapter event sets a group_key, so all were buffered in the Grouper
and never flushed (start_pipeline only started the DigestScheduler; no
tick driver existed). Fixes (per Matt's decisions):
- Grouper.handle(): immediate-severity events now BYPASS the window
entirely (delivered straight to next_handler), no buffering latency.
routine/priority still coalesce.
- start_pipeline(): schedules an asyncio flush task that calls
grouper.tick() every `grouper_flush_seconds` (default 5s) so
coalesced events drain within the window even when poll cadence is
sparse. stop_pipeline() signals + cancels it.
before/after (grouper held_count): an immediate+group_key event used to
sit held (count 1) forever; now held_count==0 on arrival (bypassed). A
routine event is held (count 1) then drained to 0 by tick()/flush.
BUG B -- notification rules loaded as dicts, crashing the dispatcher.
Root cause (more precise than 2.16's guess): the rules coercion is NOT
missing from the multi-file loader -- it lives in _dict_to_dataclass's
explicit `elif key == "notifications"` branch, but that branch was DEAD
CODE, shadowed by the generic `if hasattr(field_type,
"__dataclass_fields__")` handler that runs first for every dataclass
field (including notifications). So Config.notifications.rules stayed a
list of dicts on ALL load paths, and Dispatcher._matching_rules threw
`AttributeError: 'dict' object has no attribute 'enabled'`. Fix: hoist
the notifications special-handling ahead of the generic handler (and drop
the now-truly-dead duplicate elif).
before/after (cfg.notifications.rules[0] type): dict -> NotificationRuleConfig.
OBS C -- empty enabled_toggles. Left as 'pass all' for v0.3 (per Matt);
added a startup WARNING in build_pipeline so operators see gating is off:
"enabled_toggles is empty -- ToggleFilter passing all events. Configure
toggles to enable gating." (confirmed firing live).
Tests:
- tests/test_pipeline_grouper.py (new): test_immediate_severity_bypasses_grouper,
test_periodic_flush_drains_routine, test_priority_is_also_coalesced_not_bypassed.
- tests/test_config_loader.py (new): test_multifile_load_coerces_notification_rules,
test_rules_attribute_access_does_not_raise (regression guards for Bug B).
- tests/test_pipeline_inhibitor_grouper.py (updated): 5 existing grouper
hold/coalesce/flush tests primed the grouper with immediate+group_key
events expecting them to be held; switched those to 'priority' (still
buffered; still outranks the routine event in the inhibitor-chain test)
to match the intended immediate-bypass behavior.
Full suite: 253 passed (was 248 + 5 new; 5 existing updated, none lost).
VERIFICATION (rebuilt prod, traced end-to-end via in-process build_pipeline
probe with a recording channel + live config):
- rules[0] type: NotificationRuleConfig (Bug B fixed).
- IMMEDIATE event: held_count==0 on emit (bypassed) -> reached
channel.deliver(): delivered=[('PROBE_RULE','E2E IMMEDIATE')].
- ROUTINE event: held_count==1 -> after flush 0 -> reached
channel.deliver(): delivered+=[('PROBE_RULE','E2E ROUTINE')].
- Natural Summit-Creek-shaped nifc wildfire_incident (routine, no
matching dispatch rule): held 1 -> after flush -> landed in the digest
accumulator (1 event). End-to-end channel.deliver evidence = the
RecChannel.deliver() calls above.
- Live container: 8 adapters, healthy, "Grouper flush task started
(every 5s)", the enabled_toggles warning fired, and NO dispatcher
AttributeError/traceback.
Follow-up (non-blocking): several Phase 2.7-2.14 categories (e.g.
wildfire_incident, earthquake_event) aren't in the category->toggle map,
so they fall to toggle 'other'. Harmless while enabled_toggles is empty
(pass-all), but should be mapped before toggle gating is turned on.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
63 lines
2.3 KiB
Python
63 lines
2.3 KiB
Python
"""Phase 2.16.1: lock in notification-rule coercion in the config loader path.
|
|
|
|
Regression guard for the bug where the generic nested-dataclass handler in
|
|
_dict_to_dataclass shadowed the explicit 'notifications' branch, leaving
|
|
cfg.notifications.rules as raw dicts (which crashed Dispatcher._matching_rules
|
|
on rule.enabled). config_loader.load_config uses this same _dict_to_dataclass.
|
|
"""
|
|
|
|
from meshai.config import Config, NotificationRuleConfig, _dict_to_dataclass
|
|
|
|
|
|
def test_multifile_load_coerces_notification_rules():
|
|
"""notifications.rules dicts are coerced to NotificationRuleConfig."""
|
|
data = {
|
|
"notifications": {
|
|
"enabled": True,
|
|
"rules": [
|
|
{
|
|
"name": "Test Rule",
|
|
"enabled": True,
|
|
"trigger_type": "condition",
|
|
"categories": ["earthquake_event"],
|
|
"min_severity": "routine",
|
|
"delivery_type": "mesh_broadcast",
|
|
},
|
|
{
|
|
"name": "Second Rule",
|
|
"enabled": False,
|
|
"trigger_type": "condition",
|
|
"categories": ["wildfire_incident"],
|
|
"delivery_type": "email",
|
|
},
|
|
],
|
|
}
|
|
}
|
|
cfg = _dict_to_dataclass(Config, data)
|
|
rules = cfg.notifications.rules
|
|
assert len(rules) == 2
|
|
# Coerced to the dataclass, NOT left as dicts.
|
|
assert all(isinstance(r, NotificationRuleConfig) for r in rules)
|
|
# Attribute access (what Dispatcher._matching_rules needs) works.
|
|
assert rules[0].enabled is True
|
|
assert rules[0].name == "Test Rule"
|
|
assert rules[1].enabled is False
|
|
|
|
|
|
def test_rules_attribute_access_does_not_raise():
|
|
"""Dispatcher-style attribute access on every rule succeeds."""
|
|
data = {
|
|
"notifications": {
|
|
"rules": [
|
|
{"name": "R", "enabled": True, "trigger_type": "condition",
|
|
"categories": ["earthquake_event"], "min_severity": "immediate"},
|
|
]
|
|
}
|
|
}
|
|
cfg = _dict_to_dataclass(Config, data)
|
|
for r in cfg.notifications.rules:
|
|
# These are the accesses Dispatcher._matching_rules performs.
|
|
_ = r.enabled
|
|
_ = r.trigger_type
|
|
_ = r.categories
|
|
_ = r.min_severity
|