meshai/work/tests/test_mesh_send_api.py
Matt Johnson 4138ebfdc3 feat(meshcore): self-advertisement (send-advert + advert-on-connect + periodic)
AIDA now announces itself: send_advert(flood=True) on every connect, an
optional periodic auto-advert (meshcore_advert_interval_seconds), and a
manual "Send Advert" button + POST /api/meshcore/advert. Makes the
companion discoverable/DM-able on the mesh.
2026-07-03 22:06:09 +00:00

352 lines
11 KiB
Python

"""API tests for the dashboard 'send test message' routes.
Uses a bare FastAPI() + TestClient with a hand-seeded ``app.state.connector``
(MagicMock-based fakes). The connector fakes mimic a CompositeTransport:
``transport_name=None`` and an explicit iterable ``children`` list.
"""
from __future__ import annotations
from unittest.mock import MagicMock
import pytest
from fastapi import FastAPI
from fastapi.testclient import TestClient
from meshai.dashboard.api.mesh_send_routes import router
def _child(transport_name, connected=True, known=None):
"""Build a fake child transport (meshtastic/meshcore)."""
c = MagicMock()
c.transport_name = transport_name
c.connected = connected
if known is not None:
c.known_channels.return_value = list(known)
return c
def _composite(children, send_result=True):
"""Build a fake CompositeTransport connector wrapping *children*.
A bare MagicMock's auto-attrs are truthy and ``children`` is not
iterable, so set both explicitly.
"""
connector = MagicMock()
connector.transport_name = None
connector.children = list(children)
connector.send_message.return_value = send_result
return connector
def _client(connector):
app = FastAPI()
app.include_router(router, prefix="/api")
app.state.connector = connector
return TestClient(app)
# ============================================================================
# POST /api/mesh/test-send — meshcore
# ============================================================================
def test_meshcore_success():
mc = _child("meshcore", connected=True, known=["aida", "emergency"])
connector = _composite([mc], send_result=True)
client = _client(connector)
r = client.post("/api/mesh/test-send", json={"transport": "meshcore", "channel": "aida"})
assert r.status_code == 200
body = r.json()
assert body["sent"] is True
assert "aida" in body["detail"]
connector.send_message.assert_called_once()
_, kwargs = connector.send_message.call_args
assert kwargs["meshcore_channel"] == "aida"
assert kwargs["transport"] == "meshcore"
assert kwargs["destination"] is None
def test_meshcore_unknown_channel():
mc = _child("meshcore", connected=True, known=["aida"])
connector = _composite([mc], send_result=False)
client = _client(connector)
r = client.post("/api/mesh/test-send", json={"transport": "meshcore", "channel": "ghost"})
assert r.status_code == 200
body = r.json()
assert body["sent"] is False
assert "not on companion" in body["detail"]
assert "aida" in body["detail"]
def test_meshcore_inactive():
mt = _child("meshtastic", connected=True)
connector = _composite([mt])
client = _client(connector)
r = client.post("/api/mesh/test-send", json={"transport": "meshcore", "channel": "aida"})
assert r.status_code == 200
body = r.json()
assert body["sent"] is False
assert body["detail"] == "meshcore not connected"
# ============================================================================
# POST /api/mesh/test-send — meshtastic
# ============================================================================
def test_meshtastic_success():
mt = _child("meshtastic", connected=True)
connector = _composite([mt], send_result=True)
client = _client(connector)
r = client.post("/api/mesh/test-send", json={"transport": "meshtastic", "channel": 0})
assert r.status_code == 200
body = r.json()
assert body["sent"] is True
connector.send_message.assert_called_once()
_, kwargs = connector.send_message.call_args
assert kwargs["channel"] == 0
assert kwargs["transport"] == "meshtastic"
# ============================================================================
# Default text
# ============================================================================
def test_default_text_when_omitted():
mc = _child("meshcore", connected=True, known=["aida"])
connector = _composite([mc], send_result=True)
client = _client(connector)
r = client.post("/api/mesh/test-send", json={"transport": "meshcore", "channel": "aida"})
assert r.status_code == 200
assert r.json()["sent"] is True
args, kwargs = connector.send_message.call_args
sent_text = kwargs["text"] if "text" in kwargs else args[0]
assert isinstance(sent_text, str)
assert sent_text.startswith("🧪 MeshAI test")
# ============================================================================
# GET /api/meshcore/channels
# ============================================================================
def test_meshcore_channels_active():
mc = _child("meshcore", connected=True, known=["aida", "emergency"])
connector = _composite([mc])
client = _client(connector)
r = client.get("/api/meshcore/channels")
assert r.status_code == 200
assert r.json() == {"active": True, "channels": ["aida", "emergency"]}
def test_meshcore_channels_no_meshcore():
mt = _child("meshtastic", connected=True)
connector = _composite([mt])
client = _client(connector)
r = client.get("/api/meshcore/channels")
assert r.status_code == 200
assert r.json() == {"active": False, "channels": []}
# ============================================================================
# GET /api/meshcore/contacts
# ============================================================================
_SAMPLE_ROSTER = [
{
"name": "Repeater One",
"pubkey": "aa11deadbeef",
"type": "repeater",
"last_advert": 1000,
"lat": 43.6,
"lon": -116.2,
"out_path_len": 2,
},
{
"name": "Sensor Two",
"pubkey": "bb22cafef00d",
"type": "sensor",
"last_advert": 2000,
"lat": None,
"lon": None,
"out_path_len": -1,
},
]
def test_meshcore_contacts_active():
mc = _child("meshcore", connected=True)
mc.get_contacts.return_value = list(_SAMPLE_ROSTER)
connector = _composite([mc])
client = _client(connector)
r = client.get("/api/meshcore/contacts")
assert r.status_code == 200
assert r.json() == {"active": True, "contacts": _SAMPLE_ROSTER}
def test_meshcore_contacts_no_meshcore():
mt = _child("meshtastic", connected=True)
connector = _composite([mt])
client = _client(connector)
r = client.get("/api/meshcore/contacts")
assert r.status_code == 200
assert r.json() == {"active": False, "contacts": []}
def test_meshcore_contacts_disconnected():
mc = _child("meshcore", connected=False)
connector = _composite([mc])
client = _client(connector)
r = client.get("/api/meshcore/contacts")
assert r.status_code == 200
assert r.json() == {"active": False, "contacts": []}
# ============================================================================
# GET /api/meshcore/self
# ============================================================================
def test_meshcore_self_active():
mc = _child("meshcore", connected=True)
mc.self_info.return_value = {
"name": "AIDA",
"pubkey": "deadbeef1234",
"connected": True,
"host": "100.64.0.9",
"port": 5050,
"channel_count": 2,
}
connector = _composite([mc])
client = _client(connector)
r = client.get("/api/meshcore/self")
assert r.status_code == 200
body = r.json()
assert body["connected"] is True
assert body["pubkey"] == "deadbeef1234"
assert body["name"] == "AIDA"
assert body["channel_count"] == 2
def test_meshcore_self_no_meshcore():
mt = _child("meshtastic", connected=True)
connector = _composite([mt])
client = _client(connector)
r = client.get("/api/meshcore/self")
assert r.status_code == 200
assert r.json() == {"connected": False}
def test_meshcore_self_disconnected():
mc = _child("meshcore", connected=False)
connector = _composite([mc])
client = _client(connector)
r = client.get("/api/meshcore/self")
assert r.status_code == 200
assert r.json() == {"connected": False}
# ============================================================================
# POST /api/meshcore/advert
# ============================================================================
def test_meshcore_advert_connected_returns_sent_true():
"""POST /api/meshcore/advert → {sent: true} when meshcore is connected."""
mc = _child("meshcore", connected=True)
mc.send_advert.return_value = True
connector = _composite([mc])
client = _client(connector)
r = client.post("/api/meshcore/advert")
assert r.status_code == 200
body = r.json()
assert body["sent"] is True
assert "detail" in body
mc.send_advert.assert_called_once()
def test_meshcore_advert_connected_send_returns_false():
"""POST /api/meshcore/advert → {sent: false} when send_advert() returns False."""
mc = _child("meshcore", connected=True)
mc.send_advert.return_value = False
connector = _composite([mc])
client = _client(connector)
r = client.post("/api/meshcore/advert")
assert r.status_code == 200
body = r.json()
assert body["sent"] is False
def test_meshcore_advert_not_connected():
"""POST /api/meshcore/advert → {sent: false, detail: 'MeshCore not connected'}."""
mc = _child("meshcore", connected=False)
connector = _composite([mc])
client = _client(connector)
r = client.post("/api/meshcore/advert")
assert r.status_code == 200
body = r.json()
assert body["sent"] is False
assert body["detail"] == "MeshCore not connected"
def test_meshcore_advert_no_meshcore_child():
"""POST /api/meshcore/advert → {sent: false} when there is no meshcore transport."""
mt = _child("meshtastic", connected=True)
connector = _composite([mt])
client = _client(connector)
r = client.post("/api/meshcore/advert")
assert r.status_code == 200
body = r.json()
assert body["sent"] is False
assert body["detail"] == "MeshCore not connected"
# ============================================================================
# Config round-trip: meshcore_advert_interval_seconds
# ============================================================================
def test_connection_config_advert_interval_default():
"""meshcore_advert_interval_seconds defaults to 10800 (3 h)."""
from meshai.config import ConnectionConfig
cfg = ConnectionConfig()
assert cfg.meshcore_advert_interval_seconds == 10800
def test_connection_config_advert_interval_zero():
"""meshcore_advert_interval_seconds = 0 disables periodic advert."""
from meshai.config import ConnectionConfig
cfg = ConnectionConfig(meshcore_advert_interval_seconds=0)
assert cfg.meshcore_advert_interval_seconds == 0
def test_connection_config_advert_interval_round_trips_yaml():
"""meshcore_advert_interval_seconds survives YAML serialize → deserialize."""
from meshai.config import ConnectionConfig, _dataclass_to_dict, _dict_to_dataclass
cfg = ConnectionConfig(meshcore_advert_interval_seconds=7200)
data = _dataclass_to_dict(cfg)
assert data["meshcore_advert_interval_seconds"] == 7200
cfg2 = _dict_to_dataclass(ConnectionConfig, data)
assert cfg2.meshcore_advert_interval_seconds == 7200