mirror of
https://github.com/zvx-echo6/meshai.git
synced 2026-08-26 17:31:34 +00:00
chore(wzdx): remove two dead config fields (#150)
Both were fully plumbed and read by nothing.
api_key -- self-documented as dead at config.py ("Keyless: api_key is
retained but unused"), yet wired end-to-end: a GUI ManagedSecret field, a
SECRET_FIELDS entry, an EXPECTED_SECRETS entry, a secrets_store mapping and
label, and a line in .env.example. env/wzdx.py assigned self._api_key and
never read it again. So an operator could go get an API key, paste it into
the secure secrets manager, and have it do precisely nothing -- the ritual
looked complete end to end, which is what made it worth removing rather
than leaving.
endpoints -- default ["/get/event"], exposed as an editable list in the
dashboard, never read. Copy-paste from Roads511Config.endpoints (which IS
read, at env/roads511.py; Roads511 is untouched here). WZDx discovers feeds
via the FHWA registry_url/states instead.
WZDx's actual fetch behavior is unchanged; this removes dead config only.
Note for existing installs: anyone with WZDX_API_KEY set in
/data/secrets/.env will simply have an ignored env var. Harmless -- it was
already ignored.
Suite: 2337 passed, 6 failed (the pre-existing set: stale SCHEMA_VERSION x3,
expired TLE fixtures x2, one order-dependent), 72 skipped -- exact baseline
match, no new failures.
Co-authored-by: Matt Johnson <mj@k7zvx.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
3c900091d7
commit
e9153943bf
10 changed files with 3 additions and 23 deletions
|
|
@ -35,7 +35,6 @@ def mock_config():
|
|||
return SimpleNamespace(
|
||||
enabled=True,
|
||||
feed_source="native",
|
||||
api_key="",
|
||||
base_url="",
|
||||
registry_url="https://datahub.transportation.gov/resource/69qe-yiui.json?$limit=200",
|
||||
registry_ttl=21600,
|
||||
|
|
|
|||
|
|
@ -97,7 +97,6 @@ def test_roads511_fallback_to_config():
|
|||
|
||||
def _wzdx_cfg(states=None, bbox=None):
|
||||
cfg = MagicMock()
|
||||
cfg.api_key = ""
|
||||
cfg.base_url = ""
|
||||
cfg.registry_url = "https://example.test/registry.json"
|
||||
cfg.registry_ttl = 21600
|
||||
|
|
|
|||
|
|
@ -131,7 +131,7 @@ def test_env_to_fields_llm():
|
|||
def test_secret_labels_keys():
|
||||
expected = {
|
||||
"GOOGLE_API_KEY", "OPENAI_API_KEY", "ANTHROPIC_API_KEY", "LLM_API_KEY",
|
||||
"TOMTOM_API_KEY", "FIRMS_MAP_KEY", "ROADS511_API_KEY", "WZDX_API_KEY",
|
||||
"TOMTOM_API_KEY", "FIRMS_MAP_KEY", "ROADS511_API_KEY",
|
||||
"SMTP_PASSWORD", "MESHMONITOR_API_TOKEN", "MQTT_PASSWORD",
|
||||
}
|
||||
assert set(secrets_store.SECRET_LABELS.keys()) == expected
|
||||
|
|
|
|||
|
|
@ -25,7 +25,6 @@ def mock_config():
|
|||
return SimpleNamespace(
|
||||
enabled=True,
|
||||
feed_source="native",
|
||||
api_key="",
|
||||
base_url="",
|
||||
registry_url="https://datahub.transportation.gov/resource/69qe-yiui.json?$limit=200",
|
||||
registry_ttl=21600,
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue