chore: excise the dead Central NATS consumer path (-11,328 LOC) (#144)

* chore: excise the dead Central NATS consumer path

Central was retired and its database dropped 2026-07-15; its NATS broker no
longer exists. Verified against the live CT108 deployment: all 12 adapters
run feed_source=native, zero on central, and central.enabled is False
(default, never overridden). The consumer and its handlers were unreachable.

Removed:
- central/consumer.py and 6 dead handlers (nws, quake, swpc, nwis, avy,
  incident) -- their handle_* entrypoints were reachable only from the
  consumer's dispatch
- the Central wiring in main.py (init, guarded start, retry loop, stop path)
- the dead config surface: CentralConsumerConfig, EnvironmentalConfig.central,
  adapter_config ("central","severity_thresholds") and its display block
- the nats-py dependency (consumer.py was its only importer)
- 19 test files that exercised only the dead path

KEPT -- these live under central/ but are imported directly by native
adapters, and deleting them would break production:
- wfigs_handler.py: firms_handler._handle_pass_boundary() calls its _render()
  on the live FIRMS growth-fire path (env/firms.py -> ingest_hotspot_pixel)
- firms_handler, satpass_handler, tle_handler: split files whose handle_*
  entrypoints are dead but whose engines are live. Left intact; splitting
  them is separate work.
- pass_predictor, budget, idaho_gauge_sites: fully live.

The usgs_quake keys global_mag_floor / regional_mag_floor / regional_centroid
/ regional_radius_mi / broadcast_pager_alerts are NOT removed despite comments
labelling them "CENTRAL-PATH ONLY" -- notifications/gating/quake.py reads them
unconditionally in the native path. Those comments are corrected separately.

Test-count note: the suite drops ~425 tests. Most were migration PARITY tests
whose sole purpose was proving the native rewrite byte-matched the Central
handler (golden byte-parity, cross-source identity, gate-sequence replay).
With the handler deleted there is nothing left to compare against, so they
cannot exist. Native-only tests were kept and reworked where a test reached
for a central symbol incidentally. This is a real coverage loss, accepted
deliberately: the parity harness proved the refactor faithful, and git
history preserves the originals.

Suite: 1984 passed, 6 failed -- the same 6 pre-existing failures as main
(stale SCHEMA_VERSION x3, expired TLE fixtures x2, one order-dependent),
all being fixed on fix/green-test-suite. No new failures.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(nws): restore native-only golden coverage for the wire formatter

Commit ca751fb5 deleted the Central nws_handler parity harness along with
the handler itself, which took the ONLY tests that pinned formatters.nws
.format()'s literal wire output. Gate-sequence and schema-conformance
tests already survived natively; the formatter's actual rendered text did
not have any native-only regression net.

Add TestFormatterGolden to test_nws_refactor.py: 3 real-fixture cases plus
6 hand-built pathological cases mined from the deleted test_nws_handler.py
(SVR path-sampling, the "no dangling separator" regression, TOR on-ground
vs radar-indicated, FFW flood-cause detection). Every literal was verified
by temporarily restoring the pre-excision central.nws_handler._render()
from git history (ca751fb5^) in a throwaway, uncommitted script, confirming
byte-identical output against the current native format() for all 37 real
fixtures (nws/ + nws_last/) and all 9 pathological cases, then pinning the
confirmed-matching string as the literal -- not a blind snapshot of
current behavior.

quake/swpc/avalanche/hydro/incident/fire were checked and already carry
equivalent native-only golden coverage (added directly in ca751fb5), so no
changes were needed there.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Matt Johnson <mj@k7zvx.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
malice 2026-07-17 14:03:40 -06:00 committed by GitHub
commit 9f06930a0d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
50 changed files with 643 additions and 11275 deletions

View file

@ -194,49 +194,3 @@ def test_missing_event_id_returns_none(adapter):
def test_does_not_raise_on_corrupted_dict(adapter):
"""Corrupted dict returns None without raising."""
assert adapter.to_event({"garbage": True}) is None
# ============================================================================
# Central avy_handler._render (mesh broadcast wire) -- budget-fit format.
# advice -> FIRST SENTENCE only; zone/level/source kept FULL; fits 140.
# ============================================================================
from meshai.central.avy_handler import _render as _avy_render
def test_avy_render_advice_first_sentence_only():
wire = _avy_render(
danger_level=4, danger_name="High",
zone_name="Western Mountains",
center_id="SNFAC",
travel=("Avoid all avalanche terrain today. Natural and human-triggered "
"avalanches are likely on steep slopes."),
)
# first sentence retained (with its period), the rest dropped
assert "Avoid all avalanche terrain today." in wire
assert "Natural and human-triggered" not in wire
# zone / level / source kept FULL (never abbreviated)
assert "Western Mountains" in wire
assert "High (4)" in wire
assert "SNFAC" in wire
def test_avy_render_worst_case_fits_140():
# Long multi-sentence advice paragraph -- only the first sentence is kept,
# which lets the full zone / level / source survive under the 140 budget.
wire = _avy_render(
danger_level=5, danger_name="Extreme",
zone_name="Western Mountains",
center_id="Sawtooth Avalanche Center",
travel=("Avoid all avalanche terrain today! Very dangerous conditions "
"exist across all elevations and aspects with widespread natural "
"avalanche activity likely through the afternoon and overnight."),
)
assert len(wire) <= 140, f"{len(wire)} chars:\n{wire!r}"
# zone, level, source, and the first-sentence advice all present
assert "Western Mountains" in wire
assert "Extreme (5)" in wire
assert "Sawtooth Avalanche Center" in wire
assert "Avoid all avalanche terrain today!" in wire
# first sentence terminates at the '!' -> the rest is gone
assert "Very dangerous conditions" not in wire