feat(fire): route native WFIGS through the Phase-3 growth decider (fix updates)

Completes the Phase-3 fire migration for the native adapter. env/fires.py now
emits canonical data (_kind/irwin_id/declared_at/acres/contained), native
fires bypass the received-delta gate and run the shared gating.fire.decide +
fire formatter (forward-only growth + containment + 8h cooldown + deferred
commit), and a native-only cold-start pre-pass silent-seeds old/known fires so
no backlog spam. Fixes growth/containment silence (MORA) and revives the
fires-table-backed reminders/digest. Reuses the existing decider — no dup.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Johnson 2026-07-06 20:54:10 +00:00
commit 9ab5ad58aa
6 changed files with 513 additions and 6 deletions

View file

@ -0,0 +1,273 @@
"""Native WFIGS fire -> Phase-3 growth-decider path (F1).
These tests cover the native fire migration: env/fires.py now emits canonical
`data` the shared `gating.fire.decide` reads, env/store.py routes native fires
through the decider (bypassing the received-delta `_seen` gate) with an
unconditional `fires` state-write + a cold-start silent-seed pre-pass, and the
composer renders them via the shared fire formatter. The shared decider and
formatter are REUSED unchanged.
Scenarios (mirror the gate-sequence intent of test_fire_refactor.py):
1. Cold-start silent-seed: old/undated first-sight within boot grace -> NO
broadcast, `fires` row seeded already-broadcast.
2. Growth: seeded MORA (last_bcast 2410 @ now-9h), poll 3000 -> Update; after
the deferred commit runs, last_broadcast_acres == 3000.
3. Containment rise past cooldown -> Update.
4. Unchanged OR within cooldown -> suppress (no emit).
5. Fresh ignition (first-sight, declared within 48h) -> New; does NOT re-spam
on the next unchanged poll (the state-write latched last_broadcast_*).
6. Native event carries _dedup_suffix + _severity_override +
_on_broadcast_committed onto the emitted Event; to_event stamps canonical
`data`; the composer renders it via the fire formatter with no env var.
"""
from __future__ import annotations
import pytest
from meshai.config import EnvironmentalConfig, NICFFiresConfig
from meshai.env.fires import NICFFiresAdapter
from meshai.env.store import EnvironmentalStore
from meshai.notifications.pipeline.bus import EventBus
from meshai.notifications.renderers.composer import compose_mesh_message
from meshai.persistence import close_thread_connection, init_db
from meshai.persistence import db as persistence_db
_NOW = 1_800_000_000.0 # pinned base epoch
_IRWIN = "IRWIN-MORA-0001"
class _Clock:
"""Mutable time seam so a test can advance between polls."""
def __init__(self, t: float):
self.t = t
def now(self) -> float:
return self.t
@pytest.fixture
def env(monkeypatch, tmp_path):
db_path = str(tmp_path / "fire-native.sqlite")
monkeypatch.setenv("MESHAI_DB_PATH", db_path)
persistence_db._initialised.clear()
close_thread_connection()
conn = init_db()
from meshai.adapter_config import adapter_config as _ac
_ac.invalidate()
clk = _Clock(_NOW)
monkeypatch.setattr("meshai.notifications.clock.now", clk.now)
yield conn, clk
close_thread_connection()
persistence_db._initialised.discard(db_path)
class _FakeFires:
"""Native NIFC stand-in: controllable batch, REAL to_event mapping."""
def __init__(self):
self._batch: list = []
self._real = NICFFiresAdapter(NICFFiresConfig())
def set_batch(self, evts: list) -> None:
self._batch = evts
def tick(self) -> bool:
return True
def get_events(self) -> list:
return list(self._batch)
def to_event(self, evt: dict):
return self._real.to_event(evt)
def _raw_fire(*, name="MORA", irwin=_IRWIN, acres=2410, contained=10,
declared=None, lat=44.0, lon=-115.0, state="US-ID") -> dict:
"""Mirror the raw internal dict env/fires.py::_fetch builds per fire."""
eid = f"nifc_{name.replace(' ', '_').lower()}_{state}"
return {
"source": "nifc",
"event_id": eid,
"event_type": "Wildfire",
"name": name,
"irwin_id": irwin,
"acres": acres,
"pct_contained": contained,
"contained_pct": contained,
"declared_at_epoch": declared,
"county": None,
"lat": lat,
"lon": lon,
"distance_km": None,
"nearest_anchor": None,
"severity": "routine",
"state": state,
"fetched_at": _NOW,
"expires": _NOW + 21600,
}
def _make_store():
bus = EventBus()
captured: list = []
bus.subscribe(lambda e: captured.append(e))
store = EnvironmentalStore(EnvironmentalConfig(), event_bus=bus)
adapter = _FakeFires()
store._adapters["nifc"] = adapter
return store, adapter, captured
def _seed_row(conn, *, acres, contained, last_bcast_at):
"""Manually insert an already-broadcast fires row (skips cold-start)."""
conn.execute(
"INSERT INTO fires(irwin_id, incident_name, current_acres, "
"current_contained_pct, lat, lon, state, last_event_at, "
"last_broadcast_at, last_broadcast_acres, last_broadcast_contained) "
"VALUES (?,?,?,?,?,?,?,?,?,?,?)",
(_IRWIN, "MORA", acres, contained, 44.0, -115.0, "US-ID",
int(_NOW), int(last_bcast_at), acres, contained),
)
# ── 1. cold-start silent-seed ────────────────────────────────────────────────
def test_cold_start_silent_seed_no_broadcast(env):
conn, _clk = env
store, adapter, captured = _make_store()
# First-sight, undated, within boot grace (_boot_at == now).
adapter.set_batch([_raw_fire(acres=2410, contained=10, declared=None)])
store._ingest("nifc", adapter)
assert captured == [], "cold-start must broadcast NOTHING"
row = conn.execute(
"SELECT last_broadcast_acres, last_broadcast_at, "
"last_broadcast_contained FROM fires WHERE irwin_id=?",
(_IRWIN,)).fetchone()
assert row is not None, "cold-start must seed a fires row"
assert row["last_broadcast_acres"] == 2410 # seeded == current
assert row["last_broadcast_contained"] == 10
assert row["last_broadcast_at"] is not None
# ── 2. growth after cooldown -> Update + commit latches ─────────────────────
def test_growth_update_and_commit(env):
conn, clk = env
store, adapter, captured = _make_store()
_seed_row(conn, acres=2410, contained=10, last_bcast_at=_NOW - 9 * 3600)
adapter.set_batch([_raw_fire(acres=3000, contained=10)])
store._ingest("nifc", adapter)
assert len(captured) == 1, "growth past cooldown must broadcast Update"
ev = captured[0]
assert ev.data.get("is_update") is True
assert ev.data.get("last_bcast_acres") == 2410
commit = ev.data.get("_on_broadcast_committed")
assert callable(commit), "Update must arm the deferred commit"
commit(clk.now())
row = conn.execute(
"SELECT last_broadcast_acres FROM fires WHERE irwin_id=?",
(_IRWIN,)).fetchone()
assert row["last_broadcast_acres"] == 3000, "commit must latch new acres"
# ── 3. containment rise past cooldown -> Update ─────────────────────────────
def test_containment_rise_update(env):
conn, _clk = env
store, adapter, captured = _make_store()
_seed_row(conn, acres=2410, contained=10, last_bcast_at=_NOW - 9 * 3600)
adapter.set_batch([_raw_fire(acres=2410, contained=55)])
store._ingest("nifc", adapter)
assert len(captured) == 1, "containment rise past cooldown must broadcast"
assert captured[0].data.get("is_update") is True
# ── 4. unchanged OR within cooldown -> suppress ─────────────────────────────
def test_within_cooldown_suppresses(env):
conn, _clk = env
store, adapter, captured = _make_store()
# Growth present but last broadcast only 1h ago -> inside 8h cooldown.
_seed_row(conn, acres=2410, contained=10, last_bcast_at=_NOW - 3600)
adapter.set_batch([_raw_fire(acres=3000, contained=10)])
store._ingest("nifc", adapter)
assert captured == [], "growth inside cooldown must be suppressed"
def test_no_change_suppresses(env):
conn, _clk = env
store, adapter, captured = _make_store()
_seed_row(conn, acres=2410, contained=10, last_bcast_at=_NOW - 9 * 3600)
adapter.set_batch([_raw_fire(acres=2410, contained=10)])
store._ingest("nifc", adapter)
assert captured == [], "no forward change must be suppressed"
# ── 5. fresh ignition -> New, and no re-spam on the next unchanged poll ──────
def test_fresh_ignition_new_then_no_respam(env):
conn, clk = env
store, adapter, captured = _make_store()
fresh = dict(name="FRESH", irwin="IRWIN-FRESH-9", acres=120, contained=0,
declared=_NOW - 3600) # 1h old -> genuine fresh ignition
adapter.set_batch([_raw_fire(**fresh)])
store._ingest("nifc", adapter)
assert len(captured) == 1, "fresh ignition must broadcast New"
ev = captured[0]
assert ev.data.get("category") == "wildfire_declared"
assert ev.data.get("is_update") is False
# Latch the New broadcast.
ev.data["_on_broadcast_committed"](clk.now())
# Next poll, unchanged, even well past cooldown -> must NOT re-broadcast.
clk.t = _NOW + 10 * 3600
captured.clear()
adapter.set_batch([_raw_fire(**fresh)])
store._ingest("nifc", adapter)
assert captured == [], "latched New must not re-spam on unchanged re-poll"
# ── 6. stamps + canonical data + formatter render ───────────────────────────
def test_event_carries_stamps_and_renders_via_formatter(env):
conn, _clk = env
store, adapter, captured = _make_store()
_seed_row(conn, acres=2410, contained=10, last_bcast_at=_NOW - 9 * 3600)
adapter.set_batch([_raw_fire(acres=3000, contained=20)])
store._ingest("nifc", adapter)
assert len(captured) == 1
ev = captured[0]
# decider stamps present
assert ev.data.get("_dedup_suffix") == "3000|20"
assert ev.data.get("_severity_override") == "priority"
assert callable(ev.data.get("_on_broadcast_committed"))
# canonical data from to_event
assert ev.data.get("_kind") == "wfigs_incident"
assert ev.data.get("irwin_id") == _IRWIN
assert ev.data.get("acres") == 3000
assert ev.data.get("contained_pct") == 20
# composer renders native fire via the shared fire formatter (no env var):
wire = compose_mesh_message(ev)
assert "MORA" in wire and "Update" in wire and wire.startswith("\U0001f525")
def test_to_event_stamps_canonical_data(env):
_conn, _clk = env
adapter = _FakeFires()
ev = adapter.to_event(_raw_fire(acres=555, contained=30, declared=_NOW))
assert ev is not None
assert ev.category == "wildfire_incident"
assert ev.data["_kind"] == "wfigs_incident"
assert ev.data["irwin_id"] == _IRWIN
assert ev.data["acres"] == 555
assert ev.data["contained_pct"] == 30
assert ev.data["declared_at_epoch"] == _NOW
assert ev.data["lat"] == 44.0 and ev.data["state"] == "US-ID"