matt/meshai
1
0
Fork 0
mirror of https://github.com/zvx-echo6/meshai.git synced 2026-08-26 17:31:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

refactor(transport): derive active transports from config, drop transport setting (#13)

Browse source 
* refactor(transport): derive active transports from config, drop transport setting

A mesh is active when its connection is configured: Meshtastic is the
always-on base; MeshCore runs whenever meshcore_host is set (blank = off);
both configured = both. Removes the transport mode field/toggle entirely
so there's no separate flag to miss.

* docs: fix stale transport comment after field removal

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Matt Johnson <mj@k7zvx.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
malice 2026-07-03 00:18:53 -06:00 • committed by GitHub
commit 47b56adab5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 128 additions and 144 deletions
Download patch file Download diff file Expand all files Collapse all files

12
work/tests/test_uniform_sizing.py
View file

@ -89,17 +89,16 @@ from meshai.notifications.pipeline import build_pipeline # noqa: E402
# ---------------------------------------------------------------------------
def _mt_config(**overrides):
"""Return a ConnectionConfig wired for meshtastic (default)."""
cfg = ConnectionConfig(transport="meshtastic")
"""Return a ConnectionConfig with no MeshCore host (Meshtastic-only)."""
cfg = ConnectionConfig() # meshcore_host defaults to "" → Meshtastic only
for k, v in overrides.items():
setattr(cfg, k, v)
return cfg
def _mc_config(**overrides):
"""Return a ConnectionConfig wired for meshcore."""
"""Return a ConnectionConfig with meshcore_host set (activates MeshCore)."""
cfg = ConnectionConfig(
transport="meshcore",
meshcore_host="127.0.0.1",
meshcore_port=5050,
)
@ -158,7 +157,7 @@ class TestTransportMaxChars:
"""Sanity: all transports + CompositeTransport report mesh_max_chars=140.
This is the canonical single-budget guarantee: Meshtastic, MeshCore,
and the composite (transport=both) all resolve to the same constant.
and the composite (meshcore_host set) all resolve to the same constant.
"""
from meshai.config import ConnectionConfig
from meshai.transport.composite_transport import CompositeTransport
@ -169,9 +168,8 @@ class TestTransportMaxChars:
# MeshCore
assert MeshCoreTransport(_mc_config()).max_chars == 140
# Composite (built via factory with transport="both")
# Composite — derived from meshcore_host being non-empty
cfg_both = ConnectionConfig(
transport="both",
type="tcp",
tcp_host="127.0.0.1",
tcp_port=4403,