fix: correct satpass_handler wire field names + add pass. category prefix

satpass_handler.py: fix 6 field reads to match actual Central NATS
wire names (max_elevation_deg, satellite_name, observer_name/slug,
aos_time, los_time, azimuth_at_peak_compass).

consumer.py: add pass. prefix to _CATEGORY_MAP so
pass.n2yo_visualpasses routes to sat_pass instead of default-deny.
Add sat domain fallback to _SUBJECT_DOMAIN_CATEGORY.

Tests: 9 new tests using verbatim live NOAA-18 envelope from
central.sat.pass.us.id.filer (2026-06-10). Updates existing
test_satpass_handler.py fixtures to match corrected wire names.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

tests/test_satpass_handler.py

@@ -15,16 +15,16 @@ def _envelope(norad_id=25544, sat_name="ISS", observer="Boise",
         "id": f"pass-{norad_id}-{aos}",
         "data": {
             "adapter": "n2yo_visualpasses",
-            "category": "sat.pass",
+            "category": "pass.n2yo_visualpasses",
             "severity": 0,
             "data": {
                 "norad_id": norad_id,
-                "sat_name": sat_name,
-                "observer": observer,
-                "max_elevation": max_el,
-                "aos": aos,
-                "los": los,
-                "direction": direction,
+                "satellite_name": sat_name,
+                "observer_name": observer,
+                "max_elevation_deg": max_el,
+                "aos_time": aos,
+                "los_time": los,
+                "azimuth_at_peak_compass": direction,
             }
         }
     }

tests/test_satpass_wire_fields.py

@@ -0,0 +1,243 @@
+"""Tests for satpass_handler wire field name reads.
+
+Uses the verbatim live NOAA-18 envelope captured from Central NATS
+(central.sat.pass.us.id.filer, 2026-06-10). Proves:
+ 1. Handler extracts correct norad_id, satellite_name, observer_name,
+    max_elevation_deg, aos_time, los_time from the actual wire format.
+ 2. satpass_events row is inserted with correct values.
+ 3. Envelope missing norad_id is rejected (returns None).
+ 4. Wire message format includes the correct extracted values.
+ 5. Category mapping: pass.n2yo_visualpasses -> sat_pass.
+"""
+from __future__ import annotations
+
+import json
+import time
+
+import pytest
+
+
+# ── Verbatim live NOAA-18 envelope from Central NATS ────────────────
+
+NOAA18_ENVELOPE = {
+    "id": "filer:28654:2026-06-10T04:34:40+00:00",
+    "source": "central.echo6.co",
+    "type": "central.pass.n2yo_visualpasses.v1",
+    "time": "2026-06-10T04:41:35+00:00",
+    "datacontenttype": "application/json",
+    "centralschemaversion": "1.0",
+    "centralcategory": "pass.n2yo_visualpasses",
+    "centralseverity": 1,
+    "specversion": "1.0",
+    "data": {
+        "id": "filer:28654:2026-06-10T04:34:40+00:00",
+        "adapter": "n2yo_visualpasses",
+        "category": "pass.n2yo_visualpasses",
+        "time": "2026-06-10T04:41:35Z",
+        "expires": None,
+        "severity": 1,
+        "geo": {
+            "centroid": [-114.6, 42.57],
+            "bbox": None,
+            "regions": ["US-ID"],
+            "primary_region": "US-ID",
+            "geometry": None,
+        },
+        "data": {
+            "observer_name": "Filer",
+            "observer_slug": "filer",
+            "observer_state": "ID",
+            "norad_id": 28654,
+            "satellite_name": "NOAA 18",
+            "aos_time": "2026-06-10T04:34:40+00:00",
+            "peak_time": "2026-06-10T04:41:35+00:00",
+            "los_time": "2026-06-10T04:48:30+00:00",
+            "max_elevation_deg": 22.69,
+            "magnitude": 6.7,
+            "azimuth_at_aos": 125.6,
+            "azimuth_at_aos_compass": "SE",
+            "azimuth_at_peak": 63.0,
+            "azimuth_at_peak_compass": "ENE",
+            "azimuth_at_los": 359.5,
+            "azimuth_at_los_compass": "N",
+            "duration_s": 630,
+        },
+    },
+}
+
+
+def _enable_satpass():
+    """Set satpass.enabled=true in the test DB."""
+    from meshai.persistence import get_db
+    from meshai.adapter_config import invalidate_cache
+    conn = get_db()
+    conn.execute(
+        "UPDATE adapter_config SET value_json='true' "
+        "WHERE adapter='satpass' AND key='enabled'"
+    )
+    # Set min_elevation low enough to accept this 22.69 deg pass
+    conn.execute(
+        "UPDATE adapter_config SET value_json='5' "
+        "WHERE adapter='satpass' AND key='min_elevation'"
+    )
+    invalidate_cache()
+
+
+# ── Handler produces correct satpass_events row ─────────────────────
+
+def test_noaa18_envelope_produces_satpass_event():
+    """Verbatim NOAA-18 envelope inserts row with correct field values."""
+    from meshai.central.satpass_handler import handle_satpass
+    from meshai.persistence import get_db
+
+    _enable_satpass()
+    if hasattr(handle_satpass, "_disabled_logged"):
+        del handle_satpass._disabled_logged
+
+    now = int(time.time())
+    wire = handle_satpass(
+        NOAA18_ENVELOPE,
+        "central.sat.pass.us.id.filer",
+        data={},
+        now=now,
+    )
+    assert wire is not None, "handler returned None -- field extraction failed"
+
+    conn = get_db()
+    rows = conn.execute(
+        "SELECT norad_id, sat_name, observer, max_elevation, aos_at, los_at "
+        "FROM satpass_events WHERE norad_id=28654"
+    ).fetchall()
+    assert len(rows) >= 1, "no satpass_events row for norad_id=28654"
+    row = rows[0]
+
+    assert row["norad_id"] == 28654
+    assert row["sat_name"] == "NOAA 18"
+    assert row["observer"] == "Filer"
+    assert abs(row["max_elevation"] - 22.69) < 0.01
+    # aos_time = 2026-06-10T04:34:40+00:00 -> epoch
+    assert row["aos_at"] is not None
+    assert row["los_at"] is not None
+    # los must be after aos
+    assert row["los_at"] > row["aos_at"]
+
+
+def test_noaa18_wire_message_format():
+    """Wire message includes satellite name, elevation, observer, direction."""
+    from meshai.central.satpass_handler import handle_satpass
+
+    _enable_satpass()
+    if hasattr(handle_satpass, "_disabled_logged"):
+        del handle_satpass._disabled_logged
+
+    wire = handle_satpass(
+        NOAA18_ENVELOPE,
+        "central.sat.pass.us.id.filer",
+        data={},
+        now=int(time.time()),
+    )
+    assert wire is not None
+
+    # Line 1: satellite name + elevation
+    assert "NOAA 18" in wire
+    assert "22" in wire  # int(22.69) = 22
+
+    # Line 2: AOS/LOS times
+    assert "AOS" in wire
+    assert "LOS" in wire
+
+    # Line 3: observer + azimuth direction
+    assert "Filer" in wire
+    assert "ENE" in wire  # azimuth_at_peak_compass
+
+
+def test_missing_norad_id_rejected():
+    """Envelope with norad_id removed returns None."""
+    from meshai.central.satpass_handler import handle_satpass
+
+    _enable_satpass()
+    if hasattr(handle_satpass, "_disabled_logged"):
+        del handle_satpass._disabled_logged
+
+    # Deep copy and remove norad_id
+    import copy
+    env = copy.deepcopy(NOAA18_ENVELOPE)
+    del env["data"]["data"]["norad_id"]
+
+    wire = handle_satpass(
+        env,
+        "central.sat.pass.us.id.filer",
+        data={},
+        now=int(time.time()),
+    )
+    assert wire is None, "handler should reject envelope without norad_id"
+
+
+def test_missing_max_elevation_deg_rejected():
+    """Envelope with max_elevation_deg removed returns None."""
+    from meshai.central.satpass_handler import handle_satpass
+
+    _enable_satpass()
+    if hasattr(handle_satpass, "_disabled_logged"):
+        del handle_satpass._disabled_logged
+
+    import copy
+    env = copy.deepcopy(NOAA18_ENVELOPE)
+    del env["data"]["data"]["max_elevation_deg"]
+
+    wire = handle_satpass(
+        env,
+        "central.sat.pass.us.id.filer",
+        data={},
+        now=int(time.time()),
+    )
+    assert wire is None, "handler should reject envelope without max_elevation_deg"
+
+
+def test_observer_fallback_to_slug():
+    """When observer_name is absent, falls back to observer_slug."""
+    from meshai.central.satpass_handler import handle_satpass
+
+    _enable_satpass()
+    if hasattr(handle_satpass, "_disabled_logged"):
+        del handle_satpass._disabled_logged
+
+    import copy
+    env = copy.deepcopy(NOAA18_ENVELOPE)
+    del env["data"]["data"]["observer_name"]
+    # observer_slug = "filer" still present
+
+    wire = handle_satpass(
+        env,
+        "central.sat.pass.us.id.filer",
+        data={},
+        now=int(time.time()),
+    )
+    assert wire is not None
+    assert "filer" in wire
+
+
+# ── Consumer category mapping ──────────────────────────────────────
+
+def test_category_map_pass_prefix():
+    """pass.n2yo_visualpasses must map to sat_pass, not other."""
+    from meshai.central.consumer import map_category
+    assert map_category("pass.n2yo_visualpasses") == "sat_pass"
+
+
+def test_category_map_pass_satpass_predict():
+    """pass.satpass_predict must map to sat_pass."""
+    from meshai.central.consumer import map_category
+    assert map_category("pass.satpass_predict") == "sat_pass"
+
+
+def test_category_map_sat_prefix_still_works():
+    """sat.pass must still map to sat_pass (backward compat)."""
+    from meshai.central.consumer import map_category
+    assert map_category("sat.pass") == "sat_pass"
+
+
+def test_subject_domain_sat_fallback():
+    """Subject central.sat.pass.* must map to sat_pass via domain fallback."""
+    from meshai.central.consumer import category_from_subject
+    assert category_from_subject("central.sat.pass.us.id.filer") == "sat_pass"