matt/meshai
1
0
Fork 0
mirror of https://github.com/zvx-echo6/meshai.git synced 2026-08-26 17:31:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

test(fire-tracker): pin config + history db to tmp_path

Browse source 
load_config() defaults HistoryConfig.database to the relative path
"conversations.db", resolved against the process CWD, so every test calling
load_config() with no override shares one file for the whole session. The
conftest DB-isolation fixture only covers MESHAI_DB_PATH, not this.

Point both the config dir and the history database at the test's tmp_path.

NOTE: this does NOT resolve the order-dependent failure -- the test still
passes standalone and fails in a full run, so the polluting state lives
somewhere other than config/history. Left failing rather than weakened;
root cause still unidentified.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Johnson 2026-07-16 18:26:07 +00:00
commit 0a9345fb5b
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
work/tests/test_fire_tracker_phase4.py
View file

@ -70,7 +70,7 @@ def test_router_scope_type_defined_before_env_check():
# =========================================================================== # ===========================================================================
def test_natural_language_fire_question_routes_to_llm(): def test_natural_language_fire_question_routes_to_llm(tmp_path):
"""The LLM DM path is the sole interface for natural-language fire """The LLM DM path is the sole interface for natural-language fire
questions. Pre-revised commit there was a `?status` intent that questions. Pre-revised commit there was a `?status` intent that
rewrote the query in-router; this test confirms the rewrite is gone rewrote the query in-router; this test confirms the rewrite is gone
@ -81,7 +81,16 @@ def test_natural_language_fire_question_routes_to_llm():
from meshai.history import ConversationHistory from meshai.history import ConversationHistory
from meshai.commands.dispatcher import create_dispatcher from meshai.commands.dispatcher import create_dispatcher
cfg = load_config() # load_config() defaults HistoryConfig.database to the relative path
# "conversations.db", resolved against the process CWD. Left alone,
# every test in the suite that calls load_config() with no override
# shares that one file for the whole pytest session, so conversation
# rows written by an unrelated, earlier-running test file can leak
# into this test's routing decision. Point both the config dir and
# the history database at this test's own tmp_path to make it
# hermetic regardless of run order.
cfg = load_config(tmp_path / "config")
cfg.history.database = str(tmp_path / "conversations.db")
history = ConversationHistory(cfg.history) history = ConversationHistory(cfg.history)
async def _run(): async def _run():