central/tests/test_consumer_doc.py
malice d92074b134
docs(2-H): consumer integration spec — docs/CONSUMER-INTEGRATION.md (#38)
Adds the consumer contract for Central's NATS event streams. Primary reader:
a Claude Code instance building MeshAI's ingestion layer. The doc IS the spec --
no "see source for details".

Opens with Matt's framing: "Central takes it all and gives it all. It's up to
the pipe to do with it what it will." Central is a faithful firehose --
adapters preserve every upstream field with no enrichment / formatting /
opinionated translation. The CloudEvents envelope adds routing + dedup support;
everything else is upstream-shaped. Where the doc lists upstream lookup
endpoints for ID-only fields, that is consumer-side convenience -- explicitly
NOT a recommendation that Central enrich.

Sections (11 total):
  1. Quick start (5-line nats-py subscribe-and-print)
  2. Connection details (URL / auth / JetStream context / stream discovery)
  3. Stream layout (7 streams, derived from streams.py registry)
  4. Subject namespace registry (Mermaid tree + full pattern table)
  5. Wire format (5a CloudEvents envelope; 5b inner Event payload)
     -- explicit callout that geo.centroid is [lon, lat] GeoJSON, NOT [lat, lon]
  6. Per-adapter reference (12 subsections, locked template)
  7. Fall-off / removal semantics (explicit subjects vs absence-as-signal)
  8. Consumer patterns (durable vs ephemeral, ack/nack/term, worked example)
  9. Dedup implementation guide (single-token vs composite-key adapters)
  10. Writing a new consumer checklist
  11. Troubleshooting

Doc length: 1878 lines (target was 600-1000 originally; revised to 1200-1800
once full-fidelity JSON examples + inciweb 3x narratives + wfigs_perimeters
polygon were folded in). Completeness wins per the design principle.

Every JSON example is verbatim from CT104. 11 examples sourced from
/tmp/nwis-build/evidence.txt (dumped via psql jsonb_pretty); the wfigs_perimeters
example is a freshly pulled smallest-active-polygon record so the doc captures
the live polygon shape without flooding the page with thousands of coordinate
pairs.

The doc is assembled by /tmp/nwis-build/build_doc.py which splices live JSON
blocks into a markdown template. The build script is local-only (not committed)
because the doc itself is the artifact; future updates regenerate by re-pulling
live evidence and re-running the assembler.

New test: tests/test_consumer_doc.py (5 tests). Parses the doc and asserts:
  - The "Stream layout" table matches central.streams.STREAMS exactly
    (stream names + subject filters).
  - The (name, subject_filter) pairs match the registry as pairs (catches
    swapped subject filters on existing streams).
  - Every adapter discovered via central.adapter_discovery.discover_adapters()
    has a per-adapter subsection -- and vice versa.
  - The subsection count equals the registry size (catches duplicates).

Verification:
  - 463/463 full suite green (was 458; +5 new consumer_doc tests).
  - Doc structure: 1 H1, 12 H2, 33 H3, 12 per-adapter sections, 1 mermaid block,
    12 JSON blocks (all parse).
  - All 12 adapters covered.
  - No regressions elsewhere.

Acceptance bars (a)-(e) verbatim:
  (a) grep "subject_for_event|_ADAPTER_REGISTRY" -> empty
  (b) all 12 adapters have per-adapter subsections
  (c) 5/5 consumer-doc tests pass
  (d) 463/463 full suite
  (e) doc length 1878 lines

markdownlint was not available on CT104; substituted an inline Python sanity
check confirming code-fence balance, JSON-block validity, and structural
integrity (12 H2 / 33 H3 / 1 mermaid).

Co-authored-by: zvx <zvx@central>
2026-05-19 14:33:51 -06:00

121 lines
4.4 KiB
Python

"""Consistency tests for docs/CONSUMER-INTEGRATION.md.
The doc is the consumer contract. These tests catch drift between the doc and
the live code:
- Every StreamEntry in src/central/streams.py must appear in the doc's
"Stream layout" table — and vice versa.
- Every adapter discovered via central.adapter_discovery.discover_adapters()
must have a per-adapter subsection (### <name>) in the doc — and vice versa.
The doc's subject patterns and per-adapter copy are NOT directly asserted (they
are operator-readable prose, not machine-parsable); the registry-level checks
guard against the most common drift (adding a stream / adapter and forgetting
to document it).
"""
import re
from pathlib import Path
from central.adapter_discovery import discover_adapters
from central.streams import STREAMS
DOC_PATH = Path(__file__).resolve().parents[1] / "docs" / "CONSUMER-INTEGRATION.md"
def _doc_text() -> str:
assert DOC_PATH.is_file(), f"missing: {DOC_PATH}"
return DOC_PATH.read_text()
def _stream_layout_rows(doc: str) -> list[tuple[str, str]]:
"""Parse the doc's "Stream layout" table -> list of (stream_name, subject_filter)."""
section_re = re.compile(
r"^## 3\. Stream layout\s*\n(.*?)(?=^## )",
re.DOTALL | re.MULTILINE,
)
m = section_re.search(doc)
assert m, "doc missing '## 3. Stream layout' section"
section = m.group(1)
rows: list[tuple[str, str]] = []
# Each row: | `CENTRAL_XX` | `central.xx.>` | ... |
row_re = re.compile(r"^\|\s*`([A-Z_]+)`\s*\|\s*`(central\.[a-z_]+\.>)`\s*\|", re.MULTILINE)
for name, subj in row_re.findall(section):
rows.append((name, subj))
return rows
def _per_adapter_subsections(doc: str) -> list[str]:
"""Pull adapter names from the per-adapter section headings: '### <adapter> — ...'.
Only counts subsections inside '## 6. Per-adapter reference'.
"""
section_re = re.compile(
r"^## 6\. Per-adapter reference\s*\n(.*?)(?=^## )",
re.DOTALL | re.MULTILINE,
)
m = section_re.search(doc)
assert m, "doc missing '## 6. Per-adapter reference' section"
section = m.group(1)
heading_re = re.compile(r"^### ([a-z_]+) — ", re.MULTILINE)
return heading_re.findall(section)
def test_doc_exists():
assert DOC_PATH.is_file(), f"doc missing: {DOC_PATH}"
def test_stream_table_matches_registry():
"""Every StreamEntry in streams.py must appear in the doc's stream layout table."""
doc_rows = _stream_layout_rows(_doc_text())
doc_names = {n for n, _ in doc_rows}
doc_filters = {f for _, f in doc_rows}
code_names = {s.name for s in STREAMS}
code_filters = {s.subject_filter for s in STREAMS}
assert doc_names == code_names, (
f"stream-name drift: doc-only={doc_names - code_names}, "
f"code-only={code_names - doc_names}"
)
assert doc_filters == code_filters, (
f"subject-filter drift: doc-only={doc_filters - code_filters}, "
f"code-only={code_filters - doc_filters}"
)
def test_stream_table_name_subject_pairs_consistent():
"""Each (stream_name, subject_filter) pair in the doc must match the registry exactly.
Catches the case where someone swaps the subject filter on one stream
without updating its row.
"""
doc_rows = set(_stream_layout_rows(_doc_text()))
code_rows = {(s.name, s.subject_filter) for s in STREAMS}
assert doc_rows == code_rows, (
f"row drift: doc-only={doc_rows - code_rows}, code-only={code_rows - doc_rows}"
)
def test_every_adapter_has_a_subsection():
"""Every adapter discovered in central.adapters must have a per-adapter doc subsection."""
doc_adapters = set(_per_adapter_subsections(_doc_text()))
code_adapters = set(discover_adapters().keys())
assert doc_adapters == code_adapters, (
f"adapter coverage drift: doc-only={doc_adapters - code_adapters}, "
f"code-only={code_adapters - doc_adapters}"
)
def test_subsections_appear_in_doc_order_matches_registry_size():
"""Sanity: the count of '### <adapter>' headings inside §6 equals the registry size.
Independent count check; catches the case where one heading is duplicated.
"""
doc_adapters = _per_adapter_subsections(_doc_text())
assert len(doc_adapters) == len(set(doc_adapters)), (
f"duplicate per-adapter sections: {[a for a in doc_adapters if doc_adapters.count(a) > 1]}"
)
assert len(doc_adapters) == len(discover_adapters())