mirror of
https://github.com/zvx-echo6/central.git
synced 2026-05-22 02:24:38 +02:00
fix(csrf): replace fastapi-csrf-protect with session-bound CSRF
Fixes CSRF race condition where every GET rotated the CSRF token, causing POST failures when users had multiple tabs or slow connections. Changes: - Remove fastapi-csrf-protect dependency - Add session-bound CSRF tokens stored in config.sessions table - Add pre-auth CSRF for unauthenticated routes (/login, /setup/operator) - Add csrf.py module for pre-auth token generation/validation - Update routes to use new CSRF token handling - Add migration 013 to add csrf_token column to sessions The session-bound approach ensures CSRF tokens remain stable for the duration of a session, eliminating the race condition. Note: Route tests (test_wizard.py, test_adapters.py, etc.) need refactoring to mock get_settings() instead of CsrfProtect dependency. Core auth/CSRF handler tests pass (74 tests). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
parent
84044a4d45
commit
c317c9ab01
11 changed files with 410 additions and 208 deletions
|
|
@ -92,29 +92,33 @@ class TestSessionManagement:
|
|||
mock_conn = MagicMock()
|
||||
mock_conn.execute = AsyncMock()
|
||||
|
||||
token, expires_at = await create_session(mock_conn, operator_id=1, lifetime_days=90)
|
||||
token, expires_at, csrf_token = await create_session(mock_conn, operator_id=1, lifetime_days=90)
|
||||
|
||||
assert len(token) == 43
|
||||
assert len(csrf_token) == 64 # 32 bytes hex = 64 chars
|
||||
mock_conn.execute.assert_called_once()
|
||||
call_args = mock_conn.execute.call_args
|
||||
assert "INSERT INTO config.sessions" in call_args[0][0]
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_session_found(self):
|
||||
"""get_session returns Operator when session exists."""
|
||||
"""get_session returns (Operator, csrf_token) when session exists."""
|
||||
mock_conn = MagicMock()
|
||||
mock_conn.fetchrow = AsyncMock(return_value={
|
||||
"id": 1,
|
||||
"username": "testuser",
|
||||
"created_at": datetime.now(timezone.utc),
|
||||
"password_changed_at": datetime.now(timezone.utc),
|
||||
"csrf_token": "test_csrf_token_12345",
|
||||
})
|
||||
|
||||
operator = await get_session(mock_conn, "valid-token")
|
||||
result = await get_session(mock_conn, "valid-token")
|
||||
|
||||
assert operator is not None
|
||||
assert result is not None
|
||||
operator, csrf_token = result
|
||||
assert operator.id == 1
|
||||
assert operator.username == "testuser"
|
||||
assert csrf_token == "test_csrf_token_12345"
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_session_not_found(self):
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue