matt/central
1
0
Fork 0
mirror of https://github.com/zvx-echo6/central.git synced 2026-08-26 17:31:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

gui: add Delivered + Confirmed (acked) columns to consumers page (#119)

Browse source 
Surfaces ConsumerInfo.delivered.consumer_seq (total delivered) and
ConsumerInfo.ack_floor.consumer_seq (total acknowledged) as new columns
on the /consumers page between WAITING and CREATED.

Reuses the existing ConsumerInfo objects already fetched — no new NATS
calls. Both fields use safe getattr access and render '—' when None.
Legend updated to clarify these are consumer-level counters, not
end-to-end mesh delivery confirmation.

Bump version 0.14.8 → 0.14.9.

Co-authored-by: Ubuntu <zvx@cortex.echo6.co>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
malice 2026-06-28 22:32:50 -06:00 • committed by GitHub
commit 9450696fe9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 50 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

40
tests/test_consumers.py
View file

@ -2,6 +2,7 @@
import os
from datetime import datetime, timezone
from types import SimpleNamespace
from unittest.mock import AsyncMock, MagicMock, patch
import pytest
@ -13,13 +14,16 @@ os.environ.setdefault("CENTRAL_NATS_URL", "nats://localhost:4222")
def _make_consumer_info(name: str, num_pending: int = 0, num_ack_pending: int = 0,
num_redelivered: int = 0, num_waiting: int = 0):
num_redelivered: int = 0, num_waiting: int = 0,
delivered_seq: int = 0, ack_floor_seq: int = 0):
ci = MagicMock()
ci.name = name
ci.num_pending = num_pending
ci.num_ack_pending = num_ack_pending
ci.num_redelivered = num_redelivered
ci.num_waiting = num_waiting
ci.delivered = SimpleNamespace(consumer_seq=delivered_seq)
ci.ack_floor = SimpleNamespace(consumer_seq=ack_floor_seq)
ci.created = datetime(2026, 5, 17, 12, 0, 0, tzinfo=timezone.utc)
return ci
@ -204,6 +208,8 @@ class TestConsumersListHtmlRender:
"num_ack_pending": 0,
"num_redelivered": 0,
"num_waiting": 0,
"delivered": 5000,
"acked": 4000,
"created": datetime(2026, 5, 17, 12, 0, 0, tzinfo=timezone.utc),
"protected": False,
},
@ -230,6 +236,8 @@ class TestConsumersListHtmlRender:
"num_ack_pending": 0,
"num_redelivered": 0,
"num_waiting": 1,
"delivered": 100,
"acked": 95,
"created": datetime(2026, 5, 17, 12, 0, 0, tzinfo=timezone.utc),
"protected": True,
},
@ -254,6 +262,8 @@ class TestConsumersListHtmlRender:
"num_ack_pending": None,
"num_redelivered": None,
"num_waiting": None,
"delivered": None,
"acked": None,
"created": None,
"protected": False,
},
@ -267,6 +277,34 @@ class TestConsumersListHtmlRender:
# The guarded fallback em dash is rendered instead
assert "—" in html
def test_delivered_and_confirmed_columns_render(self):
streams = [
{
"stream": "CENTRAL_WX",
"error": None,
"consumers": [
{
"name": "meshai-wx",
"num_pending": 10,
"num_ack_pending": 2,
"num_redelivered": 0,
"num_waiting": 1,
"delivered": 7777,
"acked": 6543,
"created": datetime(2026, 5, 17, 12, 0, 0, tzinfo=timezone.utc),
"protected": False,
},
],
},
]
html = self._render(streams)
# Delivered and Confirmed column headers are present
assert "Delivered" in html
assert "Confirmed" in html
# The actual counter values appear in the rendered HTML
assert "7777" in html
assert "6543" in html
class TestConsumersDeleteArchiveGuard:
"""POST /consumers/{stream}/archive-*/delete must be refused."""