mirror of
https://github.com/zvx-echo6/central.git
synced 2026-05-21 18:14:44 +02:00
test: add ConfigSource and hot-reload rate-limit tests
- TomlConfigSource tests: list/get adapters, watch_for_changes no-op - DbConfigSource tests: list/get adapters with DB fixtures - create_config_source factory tests - NOTIFY integration test for DbConfigSource - Rate-limit guarantee tests: - Cadence change respects last_poll time - Gap exceeding new cadence polls immediately - Enable/disable/enable respects rate limit - Multiple rapid changes no extra polls - Bootstrap flag validation tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
parent
daa7852cc0
commit
1abdf45375
2 changed files with 679 additions and 0 deletions
285
tests/test_config_source.py
Normal file
285
tests/test_config_source.py
Normal file
|
|
@ -0,0 +1,285 @@
|
|||
"""Tests for configuration source abstraction."""
|
||||
|
||||
import asyncio
|
||||
import base64
|
||||
import os
|
||||
from datetime import datetime, timezone
|
||||
from pathlib import Path
|
||||
|
||||
import asyncpg
|
||||
import pytest
|
||||
import pytest_asyncio
|
||||
|
||||
from central.config_source import (
|
||||
ConfigSource,
|
||||
TomlConfigSource,
|
||||
DbConfigSource,
|
||||
create_config_source,
|
||||
)
|
||||
from central.config_store import ConfigStore
|
||||
from central.crypto import KEY_SIZE, clear_key_cache
|
||||
|
||||
# Test database DSN
|
||||
TEST_DB_DSN = os.environ.get(
|
||||
"CENTRAL_TEST_DB_DSN",
|
||||
"postgresql://central_test:testpass@localhost/central_test",
|
||||
)
|
||||
|
||||
|
||||
@pytest.fixture(scope="session")
|
||||
def master_key_path(tmp_path_factory: pytest.TempPathFactory) -> Path:
|
||||
"""Create a master key file for the test session."""
|
||||
key = os.urandom(KEY_SIZE)
|
||||
key_path = tmp_path_factory.mktemp("keys") / "master.key"
|
||||
key_path.write_text(base64.b64encode(key).decode())
|
||||
return key_path
|
||||
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def setup_master_key(master_key_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
|
||||
"""Configure master key path for all tests."""
|
||||
clear_key_cache()
|
||||
monkeypatch.setenv("CENTRAL_DB_DSN", TEST_DB_DSN)
|
||||
monkeypatch.setenv("CENTRAL_MASTER_KEY_PATH", str(master_key_path))
|
||||
|
||||
|
||||
class TestTomlConfigSource:
|
||||
"""Tests for TOML-based config source."""
|
||||
|
||||
@pytest.fixture
|
||||
def toml_file(self, tmp_path: Path) -> Path:
|
||||
"""Create a test TOML config file."""
|
||||
toml_content = """
|
||||
[adapters.nws]
|
||||
enabled = true
|
||||
cadence_s = 60
|
||||
states = ["ID", "MT"]
|
||||
contact_email = "test@example.com"
|
||||
|
||||
[adapters.disabled_adapter]
|
||||
enabled = false
|
||||
cadence_s = 300
|
||||
states = []
|
||||
contact_email = "test@example.com"
|
||||
|
||||
[cloudevents]
|
||||
type_prefix = "central"
|
||||
source = "central.local"
|
||||
schema_version = "1.0"
|
||||
|
||||
[nats]
|
||||
url = "nats://localhost:4222"
|
||||
|
||||
[postgres]
|
||||
dsn = "postgresql://user:pass@localhost/db"
|
||||
"""
|
||||
path = tmp_path / "central.toml"
|
||||
path.write_text(toml_content)
|
||||
return path
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_list_enabled_adapters(self, toml_file: Path) -> None:
|
||||
"""list_enabled_adapters returns only enabled adapters."""
|
||||
source = TomlConfigSource(toml_file)
|
||||
adapters = await source.list_enabled_adapters()
|
||||
|
||||
assert len(adapters) == 1
|
||||
assert adapters[0].name == "nws"
|
||||
assert adapters[0].enabled is True
|
||||
assert adapters[0].cadence_s == 60
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_adapter(self, toml_file: Path) -> None:
|
||||
"""get_adapter returns correct adapter config."""
|
||||
source = TomlConfigSource(toml_file)
|
||||
|
||||
adapter = await source.get_adapter("nws")
|
||||
assert adapter is not None
|
||||
assert adapter.name == "nws"
|
||||
assert adapter.settings["states"] == ["ID", "MT"]
|
||||
assert adapter.settings["contact_email"] == "test@example.com"
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_nonexistent_adapter(self, toml_file: Path) -> None:
|
||||
"""get_adapter returns None for nonexistent adapter."""
|
||||
source = TomlConfigSource(toml_file)
|
||||
adapter = await source.get_adapter("does_not_exist")
|
||||
assert adapter is None
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_watch_for_changes_returns_immediately(self, toml_file: Path) -> None:
|
||||
"""watch_for_changes is a no-op for TOML source."""
|
||||
source = TomlConfigSource(toml_file)
|
||||
callback_called = False
|
||||
|
||||
async def callback(table: str, key: str) -> None:
|
||||
nonlocal callback_called
|
||||
callback_called = True
|
||||
|
||||
# Should return immediately without blocking
|
||||
await asyncio.wait_for(
|
||||
source.watch_for_changes(callback),
|
||||
timeout=1.0,
|
||||
)
|
||||
assert not callback_called
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_implements_protocol(self, toml_file: Path) -> None:
|
||||
"""TomlConfigSource implements ConfigSource protocol."""
|
||||
source = TomlConfigSource(toml_file)
|
||||
assert isinstance(source, ConfigSource)
|
||||
|
||||
|
||||
@pytest_asyncio.fixture
|
||||
async def db_conn() -> asyncpg.Connection:
|
||||
"""Get a direct database connection for setup/teardown."""
|
||||
conn = await asyncpg.connect(TEST_DB_DSN)
|
||||
yield conn
|
||||
await conn.close()
|
||||
|
||||
|
||||
@pytest_asyncio.fixture
|
||||
async def clean_config_schema(db_conn: asyncpg.Connection) -> None:
|
||||
"""Ensure config schema exists and is clean before each test."""
|
||||
await db_conn.execute("CREATE SCHEMA IF NOT EXISTS config")
|
||||
await db_conn.execute("""
|
||||
CREATE TABLE IF NOT EXISTS config.adapters (
|
||||
name TEXT PRIMARY KEY,
|
||||
enabled BOOLEAN NOT NULL DEFAULT true,
|
||||
cadence_s INTEGER NOT NULL,
|
||||
settings JSONB NOT NULL DEFAULT '{}'::jsonb,
|
||||
paused_at TIMESTAMPTZ,
|
||||
updated_at TIMESTAMPTZ NOT NULL DEFAULT now()
|
||||
)
|
||||
""")
|
||||
await db_conn.execute("DELETE FROM config.adapters")
|
||||
|
||||
|
||||
class TestDbConfigSource:
|
||||
"""Tests for database-backed config source."""
|
||||
|
||||
@pytest_asyncio.fixture
|
||||
async def db_source(self, clean_config_schema: None) -> DbConfigSource:
|
||||
"""Create a DbConfigSource for testing."""
|
||||
source = await DbConfigSource.create(TEST_DB_DSN)
|
||||
yield source
|
||||
await source.close()
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_list_enabled_adapters_empty(self, db_source: DbConfigSource) -> None:
|
||||
"""list_enabled_adapters returns empty list when no adapters."""
|
||||
adapters = await db_source.list_enabled_adapters()
|
||||
assert adapters == []
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_list_enabled_adapters(
|
||||
self, db_source: DbConfigSource, db_conn: asyncpg.Connection
|
||||
) -> None:
|
||||
"""list_enabled_adapters returns only enabled, non-paused adapters."""
|
||||
# Insert test adapters
|
||||
await db_conn.execute("""
|
||||
INSERT INTO config.adapters (name, enabled, cadence_s, settings)
|
||||
VALUES
|
||||
('enabled_adapter', true, 60, '{"key": "value"}'::jsonb),
|
||||
('disabled_adapter', false, 60, '{}'::jsonb),
|
||||
('paused_adapter', true, 60, '{}'::jsonb)
|
||||
""")
|
||||
await db_conn.execute("""
|
||||
UPDATE config.adapters
|
||||
SET paused_at = now()
|
||||
WHERE name = 'paused_adapter'
|
||||
""")
|
||||
|
||||
adapters = await db_source.list_enabled_adapters()
|
||||
|
||||
assert len(adapters) == 1
|
||||
assert adapters[0].name == "enabled_adapter"
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_adapter(
|
||||
self, db_source: DbConfigSource, db_conn: asyncpg.Connection
|
||||
) -> None:
|
||||
"""get_adapter returns correct adapter config."""
|
||||
await db_conn.execute("""
|
||||
INSERT INTO config.adapters (name, enabled, cadence_s, settings)
|
||||
VALUES ('test_adapter', true, 120, '{"states": ["ID"]}'::jsonb)
|
||||
""")
|
||||
|
||||
adapter = await db_source.get_adapter("test_adapter")
|
||||
|
||||
assert adapter is not None
|
||||
assert adapter.name == "test_adapter"
|
||||
assert adapter.cadence_s == 120
|
||||
assert adapter.settings == {"states": ["ID"]}
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_nonexistent_adapter(self, db_source: DbConfigSource) -> None:
|
||||
"""get_adapter returns None for nonexistent adapter."""
|
||||
adapter = await db_source.get_adapter("does_not_exist")
|
||||
assert adapter is None
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_implements_protocol(self, db_source: DbConfigSource) -> None:
|
||||
"""DbConfigSource implements ConfigSource protocol."""
|
||||
assert isinstance(db_source, ConfigSource)
|
||||
|
||||
|
||||
class TestCreateConfigSource:
|
||||
"""Tests for the config source factory function."""
|
||||
|
||||
@pytest.fixture
|
||||
def toml_file(self, tmp_path: Path) -> Path:
|
||||
"""Create a minimal TOML config file."""
|
||||
toml_content = """
|
||||
[adapters.nws]
|
||||
enabled = true
|
||||
cadence_s = 60
|
||||
states = []
|
||||
contact_email = "test@example.com"
|
||||
|
||||
[cloudevents]
|
||||
[nats]
|
||||
[postgres]
|
||||
dsn = "postgresql://test@localhost/test"
|
||||
"""
|
||||
path = tmp_path / "central.toml"
|
||||
path.write_text(toml_content)
|
||||
return path
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_create_toml_source(self, toml_file: Path) -> None:
|
||||
"""create_config_source returns TomlConfigSource for 'toml' type."""
|
||||
source = await create_config_source(
|
||||
source_type="toml",
|
||||
toml_path=toml_file,
|
||||
)
|
||||
assert isinstance(source, TomlConfigSource)
|
||||
await source.close()
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_create_db_source(self, clean_config_schema: None) -> None:
|
||||
"""create_config_source returns DbConfigSource for 'db' type."""
|
||||
source = await create_config_source(
|
||||
source_type="db",
|
||||
dsn=TEST_DB_DSN,
|
||||
)
|
||||
assert isinstance(source, DbConfigSource)
|
||||
await source.close()
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_create_toml_requires_path(self) -> None:
|
||||
"""create_config_source raises for 'toml' without path."""
|
||||
with pytest.raises(ValueError, match="toml_path required"):
|
||||
await create_config_source(source_type="toml")
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_create_db_requires_dsn(self) -> None:
|
||||
"""create_config_source raises for 'db' without dsn."""
|
||||
with pytest.raises(ValueError, match="dsn required"):
|
||||
await create_config_source(source_type="db")
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_create_unknown_type_raises(self) -> None:
|
||||
"""create_config_source raises for unknown type."""
|
||||
with pytest.raises(ValueError, match="Unknown config source type"):
|
||||
await create_config_source(source_type="unknown")
|
||||
Loading…
Add table
Add a link
Reference in a new issue